Tell the session what its PR still needs, from the item
Once an engine opens a PR, the item used to have no way back to the session that built it. Now you write the change on the item, or press Address this on a finding, and SLEDS hands it to that session. If the session has ended, SLEDS starts a new one on the PR's branch.
When the engine builds a node, its session opens a PR, and the engine follows that PR to the merge. While the session is running, it hears about failing CI and new review comments. Two things never reached it, though:
- A review that only offered advice, whether from SLEDS's own review or from a bot reviewer. Only a review marked Blocking was sent to the session. Bots were not counted at all.
- Anything at all once the session had ended. Feedback then went to a person, and that person had no way back to the session or its worktree from SLEDS.
The workaround was to reply on the PR thread and hope the session was still running.
Tell the session
While a node's PR is open, its panel on the item's route has a Tell the session box. Write what the PR still needs, in your own words, and send it. Under the box are the findings that were not sent to the session: SLEDS's own review when it passed, and what bot reviewers said on the PR. Each one has an Address this button, which sends the finding's text with its link. The session fixes it, replies on that finding's thread, and pushes to the same PR.
The engine following the PR picks the instruction up within about a minute:
- The session is still running. The instruction is typed into it.
- The session has ended. A new session starts on the same branch and worktree. It is told which PR is its own and to read that PR first. On Orca, it opens in the worktree Orca already made.
Either way, the engine goes back to following the PR until it merges. Under Sent, the item shows each instruction and what happened to it: waiting for the engine, told the session, or the session restarted on the PR's branch.
Who can send one
Only the item's driver: whoever's sled it is on, or whoever ran it. That is the same rule as answering its questions, because an instruction steers the driver's run on the driver's credentials. Anyone else can still say more on the item's thread.
Why it matters
An engine-built PR that needs one more change shouldn't mean opening a terminal, finding the worktree and starting a session by hand. The item is where the work is tracked, so it is also where you say what the PR still needs.